Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename "uiOverrideRegistry" -> "extensionsRegistry" #20628

Merged
merged 5 commits into from
Jul 6, 2022

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Jul 6, 2022

SUMMARY

Renaming uiOverrideRegistry to the better name extensionsRegistry.

Kept the old name around for backwards compatibility. It should be removed later.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #20628 (ca883ad) into master (94b3d2f) will decrease coverage by 0.16%.
The diff coverage is 83.56%.

❗ Current head ca883ad differs from pull request most recent head 9b924b8. Consider uploading reports for the commit 9b924b8 to get more accurate results

@@            Coverage Diff             @@
##           master   #20628      +/-   ##
==========================================
- Coverage   66.78%   66.62%   -0.17%     
==========================================
  Files        1754     1751       -3     
  Lines       65592    65581      -11     
  Branches     6938     6938              
==========================================
- Hits        43808    43695     -113     
- Misses      20026    20126     +100     
- Partials     1758     1760       +2     
Flag Coverage Δ
hive ?
javascript 51.85% <53.84%> (+0.03%) ⬆️
presto ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/explore/ExplorePage.tsx 0.00% <0.00%> (ø)
...t-frontend/src/explore/actions/saveModalActions.js 56.52% <0.00%> (-2.57%) ⬇️
.../explore/components/ExploreViewContainer/index.jsx 52.84% <ø> (ø)
superset-frontend/src/preamble.ts 0.00% <0.00%> (ø)
superset-frontend/src/utils/getDatasourceUid.ts 50.00% <0.00%> (-50.00%) ⬇️
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 58.77% <ø> (ø)
...-frontend/src/views/CRUD/welcome/ActivityTable.tsx 42.10% <ø> (+0.72%) ⬆️
superset/views/core.py 77.38% <ø> (ø)
...rc/dashboard/components/DashboardEmbedControls.tsx 9.43% <33.33%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b3d2f...9b924b8. Read the comment docs.

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suddjian suddjian merged commit db088e9 into master Jul 6, 2022
codyml pushed a commit to codyml/superset that referenced this pull request Jul 7, 2022
)

* uiOverrideRegistry -> extensionsRegistry

* better comments

* missed a spot

* missed another spot

* url
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
)

* uiOverrideRegistry -> extensionsRegistry

* better comments

* missed a spot

* missed another spot

* url
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the superset-extensions branch March 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants