Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-add filter-box time granularity/column #20485

Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

This PR fixes a regression in #19770 which accidentally removed several SQL controls from the filter-box visualization.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screen Shot 2022-06-23 at 11 46 34 AM

AFTER

Screen Shot 2022-06-23 at 11 48 31 AM

TESTING INSTRUCTIONS

Tested locally and verified (per the screenshots) that the missing SQL controls were re-added.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

type: 'CheckboxControl',
label: t('Show time grain dropdown'),
default: false,
description: t('Check to include time grain dropdown'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per here I think the old labels where mixed, i.e., if Druid was enabled it would include the term SQL. I opted for the clearer labels/description.

@john-bodley john-bodley marked this pull request as ready for review June 23, 2022 18:52
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #20485 (80410ed) into master (b33c23e) will not change coverage.
The diff coverage is n/a.

❗ Current head 80410ed differs from pull request most recent head d5b7d47. Consider uploading reports for the commit d5b7d47 to get more accurate results

@@           Coverage Diff           @@
##           master   #20485   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files        1740     1740           
  Lines       65156    65156           
  Branches     6900     6900           
=======================================
  Hits        43492    43492           
  Misses      19915    19915           
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/visualizations/FilterBox/controlPanel.jsx 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33c23e...d5b7d47. Read the comment docs.

@john-bodley john-bodley merged commit 661ab35 into apache:master Jun 23, 2022
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jun 23, 2022
Co-authored-by: John Bodley <john.bodley@airbnb.com>
(cherry picked from commit 661ab35)
michael-s-molina pushed a commit that referenced this pull request Jun 28, 2022
Co-authored-by: John Bodley <john.bodley@airbnb.com>
(cherry picked from commit 661ab35)
michael-s-molina pushed a commit that referenced this pull request Jun 28, 2022
Co-authored-by: John Bodley <john.bodley@airbnb.com>
(cherry picked from commit 661ab35)
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jul 6, 2022
Co-authored-by: John Bodley <john.bodley@airbnb.com>
(cherry picked from commit 661ab35)
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants