-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Re-add filter-box time granularity/column #20485
fix: Re-add filter-box time granularity/column #20485
Conversation
type: 'CheckboxControl', | ||
label: t('Show time grain dropdown'), | ||
default: false, | ||
description: t('Check to include time grain dropdown'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per here I think the old labels where mixed, i.e., if Druid was enabled it would include the term SQL. I opted for the clearer labels/description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov Report
@@ Coverage Diff @@
## master #20485 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 1740 1740
Lines 65156 65156
Branches 6900 6900
=======================================
Hits 43492 43492
Misses 19915 19915
Partials 1749 1749
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit 661ab35)
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit 661ab35)
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit 661ab35)
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit 661ab35)
SUMMARY
This PR fixes a regression in #19770 which accidentally removed several SQL controls from the filter-box visualization.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
Tested locally and verified (per the screenshots) that the missing SQL controls were re-added.
ADDITIONAL INFORMATION