Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding truncate metric control on timeseries charts #20373

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jun 14, 2022

SUMMARY

Currently, there is a mechanism that metrics truncate when there is only a single metric in time-series Charts. The original PR is at here. this PR provides a new control to show the metric.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

whether.showing.single.metric.mov

TESTING INSTRUCTIONS

  1. Create a Line chart by birht_names
  2. Select sum_num to metrics
  3. Select gender to dimension
  4. Uncheck Truncate metric, the sum_num will show in the results pane and legend
  5. Check Truncate metric, the sum_num will not show in the results pane and legend

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #20373 (1d88892) into master (ead1040) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20373   +/-   ##
=======================================
  Coverage   66.69%   66.69%           
=======================================
  Files        1739     1739           
  Lines       65153    65154    +1     
  Branches     6903     6903           
=======================================
+ Hits        43453    43454    +1     
  Misses      19947    19947           
  Partials     1753     1753           
Flag Coverage Δ
javascript 51.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 65.00% <ø> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 33.33% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 33.33% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 33.33% <ø> (ø)
...rt-echarts/src/Timeseries/Regular/controlPanel.tsx 33.33% <ø> (ø)
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 28.57% <ø> (ø)
...ugin-chart-echarts/src/Timeseries/controlPanel.tsx 28.57% <ø> (ø)
...-ui-chart-controls/src/operators/renameOperator.ts 100.00% <100.00%> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 51.28% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead1040...1d88892. Read the comment docs.

@stephenLYZ
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@stephenLYZ Ephemeral environment spinning up at http://52.12.15.11:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice Work!

@zhaoyongjie zhaoyongjie merged commit 7c252d7 into apache:master Jun 15, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants