-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding truncate metric control on timeseries charts #20373
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20373 +/- ##
=======================================
Coverage 66.69% 66.69%
=======================================
Files 1739 1739
Lines 65153 65154 +1
Branches 6903 6903
=======================================
+ Hits 43453 43454 +1
Misses 19947 19947
Partials 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2d9ddd8
to
1d88892
Compare
/testenv up |
@stephenLYZ Ephemeral environment spinning up at http://52.12.15.11:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice Work!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Currently, there is a mechanism that metrics truncate when there is only a single metric in time-series Charts. The original PR is at here. this PR provides a new control to show the metric.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
whether.showing.single.metric.mov
TESTING INSTRUCTIONS
birht_names
sum_num
to metricsgender
to dimensionTruncate metric
, thesum_num
will show in the results pane and legendTruncate metric
, thesum_num
will not show in the results pane and legendADDITIONAL INFORMATION