-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(home): Show home page tabs as pills instead of links #20257
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20257 +/- ##
==========================================
+ Coverage 66.58% 66.71% +0.13%
==========================================
Files 1738 1738
Lines 65162 65123 -39
Branches 6895 6895
==========================================
+ Hits 43387 43446 +59
+ Misses 20026 19928 -98
Partials 1749 1749
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @stephenLYZ is right, the original mocks don't have an underline for the selected state. But not sure if there is supposed to be an underline on the hover state? I'll let @kasiazjc speak to that If we get rid of the underline, we'll need to do it for the other pages as well (Databases/Datasets/Saved Queries/Query History, Alerts & Reports) |
Just waiting for CI, then I'll spin up a test env to make (reasonably) sure the CSS change doesn't have any unanticipated fallout elsewhere. |
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.218.234.108:8080. Credentials are |
screencast.2022-06-13.17-57-39.mp4
|
@yousoph |
/testenv up |
@yousoph Ephemeral environment spinning up at http://54.201.138.172:8080. Credentials are |
the other points look better to me |
@yousoph |
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.220.18.136:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
* fix(home): make to update the css style of links * fix(home): make to fix lint issue * fix(home): make to remove underline when tab is active * fix(homes): make to fix the issue of tab * fix(home): make to move styles to a tag (cherry picked from commit a833674)
* fix(home): make to update the css style of links * fix(home): make to fix lint issue * fix(home): make to remove underline when tab is active * fix(homes): make to fix the issue of tab * fix(home): make to move styles to a tag (cherry picked from commit a833674)
SUMMARY
[home] pills show as links
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
![image](https://user-images.githubusercontent.com/47900232/171860391-e87c29fc-5d64-48e7-8db9-8a9ca5755818.png)
AFTER:
![Screen Shot 2022-06-03 at 9 11 49 AM](https://user-images.githubusercontent.com/47900232/171860813-12e1d570-cd98-4643-9029-6707024eb2df.png)
TESTING INSTRUCTIONS
How to reproduce this issue
ADDITIONAL INFORMATION