chore: add event logger to reports/alerts CRUD #20249

AAfghahi · 2022-06-02T18:59:36Z

SUMMARY

Previously we did not have any tracking for Report CRUD actions, this adds that.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2022-06-02T19:12:53Z

Codecov Report

Merging #20249 (80e5ee8) into master (a813528) will decrease coverage by 11.90%.
The diff coverage is 55.82%.

❗ Current head 80e5ee8 differs from pull request most recent head 9b5baeb. Consider uploading reports for the commit 9b5baeb to get more accurate results

@@             Coverage Diff             @@
##           master   #20249       +/-   ##
===========================================
- Coverage   66.50%   54.60%   -11.91%     
===========================================
  Files        1726     1726               
  Lines       64789    64892      +103     
  Branches     6829     6832        +3     
===========================================
- Hits        43090    35432     -7658     
- Misses      19967    27728     +7761     
  Partials     1732     1732

Flag	Coverage Δ
hive	`53.66% <43.30%> (-0.02%)`	⬇️
mysql	`?`
postgres	`?`
presto	`53.52% <43.30%> (-0.02%)`	⬇️
python	`58.07% <57.03%> (-24.63%)`	⬇️
sqlite	`?`
unit	`50.13% <56.25%> (+0.13%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../shared-controls/components/RadioButtonControl.tsx	`0.00% <ø> (ø)`
...ackages/superset-ui-core/src/utils/featureFlags.ts	`100.00% <ø> (ø)`
...gins/legacy-plugin-chart-world-map/src/WorldMap.js	`0.00% <0.00%> (ø)`
.../legacy-plugin-chart-world-map/src/controlPanel.ts	`33.33% <0.00%> (-66.67%)`	⬇️
...egacy-plugin-chart-world-map/src/transformProps.js	`0.00% <0.00%> (ø)`
superset-frontend/src/SqlLab/reducers/sqlLab.js	`32.62% <0.00%> (-0.54%)`	⬇️
...tend/src/components/Datasource/DatasourceModal.tsx	`69.04% <ø> (ø)`
.../src/dashboard/components/gridComponents/Chart.jsx	`60.60% <ø> (ø)`
...set-frontend/src/explore/actions/exploreActions.ts	`50.00% <ø> (ø)`
...mponents/DataTablesPane/components/ResultsPane.tsx	`58.18% <ø> (-0.75%)`	⬇️
... and 339 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a813528...9b5baeb. Read the comment docs.

hughhhh · 2022-06-03T15:39:38Z

superset/reports/api.py

    @permission_name("delete")
+    @statsd_metrics
+    @event_logger.log_this_with_context(
+        action=lambda self, *args, **kwargs: f"{self.__class__.__name__}.data",


action=lambda self, *args, **kwargs: f"{self.__class__.__name__}.data",

hughhhh · 2022-06-03T15:40:27Z

superset/reports/api.py

@@ -416,6 +429,10 @@ def put(self, pk: int) -> Response:
    @safe
    @statsd_metrics
    @rison(get_delete_ids_schema)
+    @event_logger.log_this_with_context(
+        action=lambda self, *args, **kwargs: f"{self.__class__.__name__}.delete",


.delete_bulk

hughhhh · 2022-06-03T15:41:00Z

superset/reports/api.py

@@ -281,6 +286,10 @@ def delete(self, pk: int) -> Response:
    @statsd_metrics
    @permission_name("post")
    @requires_json
+    @event_logger.log_this_with_context(
+        action=lambda self, *args, **kwargs: f"{self.__class__.__name__}.create",


hughhhh · 2022-06-03T15:41:37Z

superset/reports/api.py

@@ -344,6 +353,10 @@ def post(self) -> Response:
    @statsd_metrics
    @permission_name("put")
    @requires_json
+    @event_logger.log_this_with_context(
+        action=lambda self, *args, **kwargs: f"{self.__class__.__name__}.modify",


add event logger to report CRUD

8e2a4e2

superset-github-bot bot added the preset-io label Jun 2, 2022

pull-request-size bot added the size/S label Jun 2, 2022

pull-request-size bot added size/L and removed size/S labels Jun 2, 2022

AAfghahi changed the title ~~chore: add event logger to report CRUD~~ chore: add event logger to reports CRUD Jun 2, 2022

AAfghahi changed the title ~~chore: add event logger to reports CRUD~~ chore: add event logger to reports/alerts CRUD Jun 2, 2022

lyndsiWilliams approved these changes Jun 2, 2022

View reviewed changes

AAfghahi force-pushed the arash.afghahi/sc-48895/add-tracking-in-superset-for-report-alert branch 2 times, most recently from d26e290 to 7aac7aa Compare June 2, 2022 21:21

added assert metric to tests

b68513c

AAfghahi force-pushed the arash.afghahi/sc-48895/add-tracking-in-superset-for-report-alert branch from 7aac7aa to b68513c Compare June 2, 2022 21:31

pull-request-size bot added size/M and removed size/L labels Jun 2, 2022

hughhhh reviewed Jun 3, 2022

View reviewed changes

AAfghahi force-pushed the arash.afghahi/sc-48895/add-tracking-in-superset-for-report-alert branch from ee0d81f to d088a21 Compare June 3, 2022 15:42

hughhhh approved these changes Jun 3, 2022

View reviewed changes

AAfghahi force-pushed the arash.afghahi/sc-48895/add-tracking-in-superset-for-report-alert branch from d088a21 to 7d8312d Compare June 3, 2022 16:16

added unique name to action

397f52c

AAfghahi force-pushed the arash.afghahi/sc-48895/add-tracking-in-superset-for-report-alert branch from 7d8312d to 397f52c Compare June 3, 2022 17:32

pull-request-size bot added size/L and removed size/M labels Jun 3, 2022

testing

36eb8fb

AAfghahi force-pushed the arash.afghahi/sc-48895/add-tracking-in-superset-for-report-alert branch 3 times, most recently from 82c0b28 to 9fedaaa Compare June 3, 2022 21:55

AAfghahi force-pushed the arash.afghahi/sc-48895/add-tracking-in-superset-for-report-alert branch from 9fedaaa to 0ff1eaf Compare June 3, 2022 22:19

with inline log context

9b5baeb

AAfghahi force-pushed the arash.afghahi/sc-48895/add-tracking-in-superset-for-report-alert branch from 0ff1eaf to 9b5baeb Compare June 3, 2022 22:26

vincentkoc approved these changes Jun 5, 2022

View reviewed changes

hughhhh merged commit c131f02 into apache:master Jun 6, 2022

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add event logger to reports/alerts CRUD #20249

chore: add event logger to reports/alerts CRUD #20249

AAfghahi commented Jun 2, 2022

codecov bot commented Jun 2, 2022 •

edited

Loading

hughhhh Jun 3, 2022

hughhhh Jun 3, 2022

hughhhh Jun 3, 2022

hughhhh Jun 3, 2022

AAfghahi Jun 3, 2022

chore: add event logger to reports/alerts CRUD #20249

chore: add event logger to reports/alerts CRUD #20249

Conversation

AAfghahi commented Jun 2, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Jun 2, 2022 • edited Loading

Codecov Report

hughhhh Jun 3, 2022

Choose a reason for hiding this comment

hughhhh Jun 3, 2022

Choose a reason for hiding this comment

hughhhh Jun 3, 2022

Choose a reason for hiding this comment

hughhhh Jun 3, 2022

Choose a reason for hiding this comment

AAfghahi Jun 3, 2022

Choose a reason for hiding this comment

codecov bot commented Jun 2, 2022 •

edited

Loading