fix: big number with trendline can't calculate cumsum #19542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
commented
Apr 6, 2022
Comment on lines
-30
to
-50
| const TIME_GRAIN_MAP: Record<string, string> = { | ||
| PT1S: 'S', | ||
| PT1M: 'min', | ||
| PT5M: '5min', | ||
| PT10M: '10min', | ||
| PT15M: '15min', | ||
| PT30M: '30min', | ||
| PT1H: 'H', | ||
| P1D: 'D', | ||
| P1M: 'MS', | ||
| P3M: 'QS', | ||
| P1Y: 'AS', | ||
| // TODO: these need to be mapped carefully, as the first day of week | ||
| // can vary from engine to engine | ||
| // P1W: 'W', | ||
| // '1969-12-28T00:00:00Z/P1W': 'W', | ||
| // '1969-12-29T00:00:00Z/P1W': 'W', | ||
| // 'P1W/1970-01-03T00:00:00Z': 'W', | ||
| // 'P1W/1970-01-04T00:00:00Z': 'W', | ||
| }; | ||
|
|
There was a problem hiding this comment.
Use explicit the Resample control to select.
Codecov Report
@@ Coverage Diff @@
## master #19542 +/- ##
=======================================
Coverage 66.59% 66.60%
=======================================
Files 1682 1682
Lines 64314 64316 +2
Branches 6559 6560 +1
=======================================
+ Hits 42832 42836 +4
+ Misses 19781 19779 -2
Partials 1701 1701
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Tested in local and LGTM. |
villebro
approved these changes
Apr 6, 2022
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit 2daa071)
|
🏷️ preset:2022.13 |
villebro
pushed a commit
that referenced
this pull request
Apr 8, 2022
(cherry picked from commit 2daa071)
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixed that the Big Number with Trendline can't calculate with
cumsum. In addition, I moved the Resample panel into the chart.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
cleaned_sales_datadataset and theBig Number with TrendlineCharta.
order dateas the TIME COLUMN.b.
Monthas the TIME GRAIN.c.
COUNT(*)as the METRIC.d.
cumsumas the ROLLING FUNCTION.ADDITIONAL INFORMATION