Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix: Use three backticks for code blocks #19331

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

kaapstorm
Copy link
Contributor

SUMMARY

Fixes a tiny issue in CONTRIBUTING.md: A code block was opened with four backticks, attempted to be closed with three backticks, and then a second code block was opened with three backticks and closed with four. The result was that the three backticks appeared inside the code block as code, along with a line of plain text.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
image

AFTER
image

TESTING INSTRUCTIONS

Rendered Markdown locally.

ADDITIONAL INFORMATION

Fixes #19330

  • Has associated issue: docs: tiny: Closing backticks and plain text appear inside code block #19330
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@srinify
Copy link
Contributor

srinify commented Mar 23, 2022

Thanks for the catch & fix!

@AAfghahi AAfghahi merged commit 3340f05 into apache:master Mar 23, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: tiny: Closing backticks and plain text appear inside code block
5 participants