feat: SupersetClient config to override 401 behavior #19144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suddjian
force-pushed
the
client-override-unauthorized
branch
from
0c7214a
to
605e281
Compare
suddjian
changed the title
suddjian
commented
Mar 19, 2022
| max-width: 600px; | ||
| position: fixed; | ||
| bottom: 0px; | ||
| ${({ position }) => (position === 'bottom' ? 'bottom' : 'top')}: 0px; |
There was a problem hiding this comment.
By default toasts are at the bottom, but the bottom of an embedded iframe could be offscreen, so for embedded it looks better to have toasts at the top.
suddjian
commented
Mar 19, 2022
suddjian
commented
Mar 19, 2022
| }); | ||
| } | ||
|
|
||
| function validateMessageEvent(event: MessageEvent) { | ||
| if ( |
There was a problem hiding this comment.
This stuff isn't required, and I think it will be more confusing long-term than not having it here.
…uperset into client-override-unauthorized
Codecov Report
@@ Coverage Diff @@
## master #19144 +/- ##
==========================================
+ Coverage 66.55% 66.56% +0.01%
==========================================
Files 1646 1643 -3
Lines 63617 63664 +47
Branches 6471 6494 +23
==========================================
+ Hits 42339 42379 +40
- Misses 19600 19602 +2
- Partials 1678 1683 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lilykuang
approved these changes
Mar 21, 2022
|
🏷️ preset:2022.11 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 21, 2022
* wip * feat: make 401 responses configurable in SupersetClient * sort * guest unauthorized handler * add toast container to embedded app * add option for toast presenter to go at the top * remove confusing comms logging * lint * Update superset-frontend/src/embedded/index.tsx * type correction (cherry picked from commit 96a123f)
michael-hoffman-26
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Mar 23, 2022
* wip * feat: make 401 responses configurable in SupersetClient * sort * guest unauthorized handler * add toast container to embedded app * add option for toast presenter to go at the top * remove confusing comms logging * lint * Update superset-frontend/src/embedded/index.tsx * type correction
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
* wip * feat: make 401 responses configurable in SupersetClient * sort * guest unauthorized handler * add toast container to embedded app * add option for toast presenter to go at the top * remove confusing comms logging * lint * Update superset-frontend/src/embedded/index.tsx * type correction (cherry picked from commit 96a123f)
9 tasks
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Requests should be able to be made without triggering the usual redirect-to-login if a 401 is returned.
Additionally, we need to have a default action other than a redirect if we get a 401 in the embedded page. This PR also adds code for Embedded so that 401s result in a toast warning instead of a redirect. We may want to change this to something other than a toast in the future, but for now it gets the job done.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before, a 401 resulted in a redirect to our login screen, which since you were already logged in to Preset, redirected to an app-in-app experience, which is pretty confusing. Now you get error messages and this explanation. Less brain-bending.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION