-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Line Chart Annotation Info Update #19001
fix: Line Chart Annotation Info Update #19001
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19001 +/- ##
==========================================
- Coverage 66.49% 66.32% -0.17%
==========================================
Files 1681 1681
Lines 64370 64370
Branches 6583 6583
==========================================
- Hits 42803 42695 -108
- Misses 19886 19994 +108
Partials 1681 1681
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Hopefully the CI Logjam will clear soon :)
@codemaster08240328 please rebase so this can pass CI. |
* fix Line Chart Annotation Info Updage * wrap annotation text with transation * resolve comment
SUMMARY
In production annotation verbiage is a bit confusing for a new user.
Feedback from Opendoor was to clarify that the chart being referenced is a chart created by the user/team.
Clear instruction should be needed.