-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nested-tab-available): make the another tabs into one tabs available #18877
fix(nested-tab-available): make the another tabs into one tabs available #18877
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18877 +/- ##
==========================================
+ Coverage 66.31% 66.32% +0.01%
==========================================
Files 1620 1634 +14
Lines 63075 63315 +240
Branches 6370 6428 +58
==========================================
+ Hits 41827 41994 +167
- Misses 19591 19641 +50
- Partials 1657 1680 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://52.40.162.64:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just delete the code (and the TODO) rather than commenting it out.
Also adding @williaster as a reviewer... he wrote this original check, so I'm not sure if there's rationale for the prevention of nested tabs that we'd want to preserve.
Pinging @graceguo-supercat for any additional historical context on why we have this limitation, in case @williaster is unavailable. |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Unable to add Tabs inside a Tab unless the Tab already has other elements (Dashboard Layout)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
![Screen Shot 2022-02-23 at 8 21 22 AM](https://user-images.githubusercontent.com/47900232/155327551-f854e303-4cd5-4f77-a416-21daf7a7d1db.png)
After:
![Screen Shot 2022-02-23 at 8 21 08 AM](https://user-images.githubusercontent.com/47900232/155327526-c1b669ee-cad1-4cfd-b9cd-995bc7105114.png)
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION