-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add ci for docs-v2 #18231
Merged
Merged
chore: add ci for docs-v2 #18231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
approved these changes
Feb 2, 2022
geido
approved these changes
Feb 2, 2022
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
ofekisr
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 8, 2022
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
This was referenced Nov 28, 2023
This was referenced Dec 6, 2023
This was referenced Dec 15, 2023
This was referenced Dec 27, 2023
This was referenced Jan 10, 2024
This was referenced Jan 18, 2024
This was referenced Jan 26, 2024
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
To ensure that our docs v2 build successfully every commit I suggest adding initial CI setup.
I can imagine applying some linting rules for documentation eg. validate links, validate referenced images (see #18090), but we need to start somewhere.
This is a followup of #18202 .
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
You can see on GitHub Actions the results of the associated CI job.
ADDITIONAL INFORMATION
@geido, could you take a look?