-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade ControlHeader to TSX & FC and add storybook #18188
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18188 +/- ##
=======================================
Coverage 66.04% 66.04%
=======================================
Files 1591 1591
Lines 62415 62421 +6
Branches 6285 6289 +4
=======================================
+ Hits 41224 41229 +5
- Misses 19569 19570 +1
Partials 1622 1622
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments, but great work otherwise!
superset-frontend/src/explore/components/ControlHeader.stories.tsx
Outdated
Show resolved
Hide resolved
/testenv up |
@geido Ephemeral environment spinning up at http://34.215.33.208:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming everything works as expected in the test env!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
…#18188) * refactor: upgrade ControlHeader to TSX & FC and add storybook * fix: Add story for error in ControlHeader * apply review comments
…#18188) * refactor: upgrade ControlHeader to TSX & FC and add storybook * fix: Add story for error in ControlHeader * apply review comments
…#18188) * refactor: upgrade ControlHeader to TSX & FC and add storybook * fix: Add story for error in ControlHeader * apply review comments
SUMMARY
Upgraded ControlHeader to TypeScript to apply direction outlined in #18100 .
Added storybook to visualize that component.
Upgraded to FC.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Storybook can be used to verify those changes.
ADDITIONAL INFORMATION
@kgabryje , @mik-laj You might be interested in this PR!