Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade ControlHeader to TSX & FC and add storybook #18188

Merged
merged 3 commits into from
Jan 31, 2022

Conversation

ad-m
Copy link
Contributor

@ad-m ad-m commented Jan 27, 2022

SUMMARY

Upgraded ControlHeader to TypeScript to apply direction outlined in #18100 .

Added storybook to visualize that component.

Upgraded to FC.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

obraz

TESTING INSTRUCTIONS

Storybook can be used to verify those changes.

ADDITIONAL INFORMATION

  • Has associated issue: see Migrate components to TypeScript #18100
  • Required feature flags: no
  • Changes UI: no
  • Includes DB Migration (follow approval process in SIP-59): no
    • Migration is atomic, supports rollback & is backwards-compatible: N/A
    • Confirm DB migration upgrade and downgrade tested: N/A
    • Runtime estimates and downtime expectations provided: N/A
  • Introduces new feature or API: no
  • Removes existing feature or API: no

@kgabryje , @mik-laj You might be interested in this PR!

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #18188 (e543e33) into master (e6bb0fc) will increase coverage by 0.00%.
The diff coverage is 82.60%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18188   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files        1591     1591           
  Lines       62415    62421    +6     
  Branches     6285     6289    +4     
=======================================
+ Hits        41224    41229    +5     
- Misses      19569    19570    +1     
  Partials     1622     1622           
Flag Coverage Δ
javascript 50.86% <82.60%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/explore/components/ControlHeader.tsx 82.60% <82.60%> (ø)
...ashboard/components/UndoRedoKeyListeners/index.jsx 100.00% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.83% <0.00%> (ø)
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 80.00% <0.00%> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 79.62% <0.00%> (ø)
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 65.07% <0.00%> (ø)
superset-frontend/src/utils/common.js 88.67% <0.00%> (+0.21%) ⬆️
...uperset-frontend/src/explore/exploreUtils/index.js 67.13% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6bb0fc...e543e33. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments, but great work otherwise!

@geido
Copy link
Member

geido commented Jan 27, 2022

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.215.33.208:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming everything works as expected in the test env!

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etr2460 etr2460 merged commit 341d855 into apache:master Jan 31, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
…#18188)

* refactor: upgrade ControlHeader to TSX & FC and add storybook

* fix: Add story for error in ControlHeader

* apply review comments
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
…#18188)

* refactor: upgrade ControlHeader to TSX & FC and add storybook

* fix: Add story for error in ControlHeader

* apply review comments
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
…#18188)

* refactor: upgrade ControlHeader to TSX & FC and add storybook

* fix: Add story for error in ControlHeader

* apply review comments
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants