Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping react syntax highlighter and thusly prismjs #17439

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

rusackas
Copy link
Member

SUMMARY

Finally managed to bump the prismjs dependency, which was at a vulnerable version due to react-syntax-highlighter. I managed to get this PR through over on that repo, so I'm pulling in the resulting bump here.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #17439 (fc14d86) into master (9741eaa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17439   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files        1042     1042           
  Lines       56248    56248           
  Branches     7784     7784           
=======================================
  Hits        43280    43280           
  Misses      12709    12709           
  Partials      259      259           
Flag Coverage Δ
hive 81.53% <ø> (ø)
javascript 71.02% <ø> (ø)
mysql 81.95% <ø> (ø)
postgres 81.96% <ø> (ø)
presto 81.83% <ø> (ø)
python 82.46% <ø> (ø)
sqlite 81.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9741eaa...fc14d86. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 96bdcc3 into master Nov 16, 2021
@rusackas rusackas deleted the bump-react-syntax-highlighter branch November 16, 2021 15:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants