Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove horizontal scroll navigation from SQL Lab #17356

Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Nov 5, 2021

SUMMARY

People commonly complain about accidentally navigating forwards or backwards in chrome when horizontally scrolling in SQL Lab. Most of our app doesn't have such a horizontal scrolling paradigm, but SQL Lab is the exception. So let's remove that horizontal scrolling navigation behavior in SQL Lab

TESTING INSTRUCTIONS

Spin up a testenv and test. make sure you can't horizontal scroll to go forward and backwards in sql lab. But when you go back to a dashboard/explore see that you can

Before:

before.with.scroll.mov

After:

after.no.scroll.mov

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @graceguo-supercat @ktmud @rusackas @michael-s-molina

@etr2460 etr2460 marked this pull request as ready for review November 5, 2021 15:27
@etr2460
Copy link
Member Author

etr2460 commented Nov 5, 2021

Marking as ready for review to get the docker build, will tag people when it's actually ready

@etr2460
Copy link
Member Author

etr2460 commented Nov 5, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

@etr2460 Ephemeral environment spinning up at http://52.35.144.201:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #17356 (2625e52) into master (fa51b32) will not change coverage.
The diff coverage is n/a.

❗ Current head 2625e52 differs from pull request most recent head cc98071. Consider uploading reports for the commit cc98071 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17356   +/-   ##
=======================================
  Coverage   77.06%   77.06%           
=======================================
  Files        1036     1036           
  Lines       55757    55757           
  Branches     7628     7628           
=======================================
  Hits        42969    42969           
  Misses      12532    12532           
  Partials      256      256           
Flag Coverage Δ
javascript 71.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa51b32...cc98071. Read the comment docs.

@etr2460 etr2460 force-pushed the erik-ritter--remove-horizontal-scroll-sqllab branch from 30cc709 to cc98071 Compare November 5, 2021 16:14
@etr2460
Copy link
Member Author

etr2460 commented Nov 5, 2021

/testenv down

@etr2460
Copy link
Member Author

etr2460 commented Nov 5, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

@etr2460 Ephemeral environment spinning up at http://18.236.74.45:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@betodealmeida
Copy link
Member

Can we turn it off for the whole app? I hate that pattern! 😆

@etr2460
Copy link
Member Author

etr2460 commented Nov 5, 2021

Can we turn it off for the whole app? I hate that pattern! 😆

We can consider it, would appreciate a UX designer/PM's take on that first

@ghost
Copy link

ghost commented Nov 5, 2021

I'd need to do some research on the accessibility issues around turning it off for the entire app, but big thumbs up to doing it here!

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@etr2460 etr2460 merged commit f05a32e into apache:master Nov 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

Ephemeral environment shutdown and build artifacts deleted.

@ktmud
Copy link
Member

ktmud commented Nov 10, 2021

@etr2460 @betodealmeida Table chart would need horizontal scrolling at least. Some other tables may also need it.

@betodealmeida
Copy link
Member

@etr2460 @betodealmeida Table chart would need horizontal scrolling at least. Some other tables may also need it.

Oh, if I understood correctly we're not getting rid of horizontal scrolling (that's also needed in SQL Lab), but navigating between pages by using horizontal scrolling.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants