Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Databricks DB engine spec #13682

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Add a DB engine spec for Databricks. Since it uses pyhive under the hood, it's just a thin wrapper.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Connecting to Databricks:

Screenshot_2021-03-17 Superset(1)

Exploring the birth_names table, after uploading it to Databricks:

Screenshot_2021-03-17 Explore - birth_names

TEST PLAN

Connected and explored data (see screenshots).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #13682 (957a82a) into master (21cc495) will decrease coverage by 6.12%.
The diff coverage is 73.45%.

❗ Current head 957a82a differs from pull request most recent head 77c0555. Consider uploading reports for the commit 77c0555 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13682      +/-   ##
==========================================
- Coverage   77.41%   71.29%   -6.13%     
==========================================
  Files         918      839      -79     
  Lines       46673    41812    -4861     
  Branches     5720     4334    -1386     
==========================================
- Hits        36131    29809    -6322     
- Misses      10406    12003    +1597     
+ Partials      136        0     -136     
Flag Coverage Δ
cypress 56.59% <56.43%> (+<0.01%) ⬆️
hive 80.25% <89.09%> (+<0.01%) ⬆️
javascript ?
mysql 80.56% <89.09%> (+<0.01%) ⬆️
postgres 80.61% <89.09%> (+<0.01%) ⬆️
presto 80.29% <87.27%> (+0.01%) ⬆️
python 81.11% <89.09%> (+0.01%) ⬆️
sqlite 80.23% <89.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 23.61% <ø> (-39.43%) ⬇️
superset-frontend/src/chart/chartAction.js 70.50% <0.00%> (-7.50%) ⬇️
...et-frontend/src/dashboard/actions/nativeFilters.ts 62.50% <ø> (-1.61%) ⬇️
...tersConfigModal/FiltersConfigForm/ControlItems.tsx 68.75% <0.00%> (-2.09%) ⬇️
...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx 7.14% <0.00%> (-92.86%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 82.14% <0.00%> (-11.28%) ⬇️
...perset-frontend/src/dashboard/containers/Chart.jsx 100.00% <ø> (ø)
...et-frontend/src/dashboard/containers/Dashboard.jsx 100.00% <ø> (ø)
...tend/src/explore/components/DisplayQueryButton.jsx 73.43% <0.00%> (-2.37%) ⬇️
superset/config.py 90.71% <ø> (ø)
... and 529 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cc495...77c0555. Read the comment docs.

@dpgaspar dpgaspar merged commit adc247b into apache:master Mar 18, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Mar 22, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants