Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Database API missing allow none on fields #10795

Merged
merged 2 commits into from
Sep 9, 2020
Merged

fix: Database API missing allow none on fields #10795

merged 2 commits into from
Sep 9, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Sep 4, 2020 •
edited
Loading

SUMMARY

Some fields on the database model are allowed None and this was not properly reflected on the marshmallow schemas

ping: @riahk

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar marked this pull request as ready for review September 7, 2020 15:10
@dpgaspar dpgaspar requested a review from nytai September 7, 2020 15:10
@dpgaspar dpgaspar merged commit 782f678 into apache:master Sep 9, 2020
@dpgaspar dpgaspar deleted the fix/database-schema branch September 9, 2020 08:35
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@dpgaspar @auxten
fix: Database API missing allow none on fields (apache#10795)
6cc53b0 
* fix: Database API missing allow none on fields

* one missing
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riahk riahk riahk approved these changes

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpgaspar @riahk @nytai @mistercrunch