fix(datasets): sort and humanized modified by #10380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
reviewed
Jul 21, 2020
| size: 'xl', | ||
| }: any) => <span className="no-wrap">{changedOn}</span>, | ||
| Header: t('Modified'), | ||
| accessor: 'changed_on_delta_humanized', |
There was a problem hiding this comment.
can you add back the size: 'xl' property which should ensure even spacing between columns
nytai
approved these changes
Jul 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #10380 +/- ##
==========================================
- Coverage 70.66% 69.71% -0.96%
==========================================
Files 601 196 -405
Lines 32267 19019 -13248
Branches 3275 0 -3275
==========================================
- Hits 22803 13259 -9544
+ Misses 9358 5760 -3598
+ Partials 106 0 -106
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix(datasets): sort and humanized modified by * size xl on changed_on_delta_humanized * Fix, tests * Fix, tests * Fix, frontend tests * remove debug flag
mistercrunch
added
🏷️ bot
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes: modified by time zone issue (same solution has for charts and dashboards).
Fixes: Sort by modified by
Introduces sort on schemas
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION