[SPARK-46332][SQL] Migrate CatalogNotFoundException to the error class CATALOG_NOT_FOUND
#44259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
CatalogNotFoundException to the error class CATALOG_NOT_FOUNDCatalogNotFoundException to the error class CATALOG_NOT_FOUND
MaxGekk
changed the title
CatalogNotFoundException to the error class CATALOG_NOT_FOUNDCatalogNotFoundException to the error class CATALOG_NOT_FOUND
dongjoon-hyun
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
+1, LGTM. Thank you, @MaxGekk .
Merged to master for Apache Spark 4.0.0.
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…ass `CATALOG_NOT_FOUND` ### What changes were proposed in this pull request? In the PR, I propose to migrate the `CatalogNotFoundException` exception to the new error class `CATALOG_NOT_FOUND`, improve the format of the exception message, and prohibit creation of the exception without the error class. ### Why are the changes needed? This is a part of the migration process onto error classes and new error framework. The changes improve user experience w/ Spark SQL, and make `CatalogNotFoundException` consistent to other Spark exceptions. ### Does this PR introduce _any_ user-facing change? Yes, if user's code depends on the error message format of `CatalogNotFoundException`. ### How was this patch tested? By running the affected test suites: ``` $ build/sbt "core/testOnly *SparkThrowableSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44259 from MaxGekk/catalog-plugin-not-found. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to migrate the
CatalogNotFoundExceptionexception to the new error classCATALOG_NOT_FOUND, improve the format of the exception message, and prohibit creation of the exception without the error class.Why are the changes needed?
This is a part of the migration process onto error classes and new error framework. The changes improve user experience w/ Spark SQL, and make
CatalogNotFoundExceptionconsistent to other Spark exceptions.Does this PR introduce any user-facing change?
Yes, if user's code depends on the error message format of
CatalogNotFoundException.How was this patch tested?
By running the affected test suites:
Was this patch authored or co-authored using generative AI tooling?
No.