Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block elasticjob-test-native module from compiling on JDK 8 to JDK16 #2427

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Aug 12, 2024

Fixes #2420 .

Changes proposed in this pull request:

  • Block elasticjob-test-native module from compiling on JDK 8 to JDK16.
  • Also fixes Force to build on JDK 17+ #2423 . I prefer the current PR handling, which even allows to compile with JDK 8 and execute unit tests of elasticjob-test-native under Spring Boot 3.3.2 in IntelliJ IDEA out of the box.
  • image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (a8ba448) to head (a21b276).
Report is 41 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2427      +/-   ##
============================================
- Coverage     80.10%   79.61%   -0.50%     
+ Complexity     1113     1106       -7     
============================================
  Files           204      204              
  Lines          3821     3806      -15     
  Branches        445      443       -2     
============================================
- Hits           3061     3030      -31     
- Misses          570      585      +15     
- Partials        190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terrymanu terrymanu merged commit 756de29 into apache:master Aug 12, 2024
16 checks passed
@linghengqian linghengqian added this to the 3.1.0 milestone Aug 12, 2024
@linghengqian linghengqian deleted the fix branch August 12, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump the minimum compilation JDK version to JDK17, while keeping the minimum runtime JDK version at JDK8
3 participants