Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-1653] Use bblot version 1.3.3 #608

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

ChinX
Copy link
Contributor

@ChinX ChinX commented Dec 9, 2019

It solves the performance problem of etcd under the large database size.
See details,
https://www.cncf.io/blog/2019/05/09/performance-optimization-of-etcd-in-web-scale-data-scenario/
etcd-io/bbolt#141

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 60.116% when pulling aa00825 on ChinX:master into c2dc0ca on apache:master.

@codecov-io
Copy link

Codecov Report

Merging #608 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   57.85%   57.82%   -0.04%     
==========================================
  Files         204      204              
  Lines       15709    15709              
==========================================
- Hits         9088     9083       -5     
- Misses       5974     5977       +3     
- Partials      647      649       +2
Impacted Files Coverage Δ
syncer/pkg/syssig/signal.go 64.51% <0%> (-3.23%) ⬇️
server/notify/websocket.go 78.85% <0%> (-2.29%) ⬇️
syncer/plugins/servicecenter/transform.go 53.57% <0%> (-0.72%) ⬇️
pkg/log/logrotate.go 33.71% <0%> (-0.58%) ⬇️
server/broker/service.go 55.85% <0%> (+0.15%) ⬆️
...erver/plugin/pkg/tracing/buildin/file_collector.go 64.07% <0%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2dc0ca...aa00825. Read the comment docs.

@tianxiaoliang tianxiaoliang merged commit 66d9fcb into apache:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants