Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-379] Fix bugs in RS_AsBase64 #994

Merged
merged 2 commits into from
Sep 1, 2023
Merged

[SEDONA-379] Fix bugs in RS_AsBase64 #994

merged 2 commits into from
Sep 1, 2023

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Sep 1, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  1. Rename the function to RS_AsBase64
  2. Fix the wrong name of RasterOutputTests. This stopped JUnit from picking up the tests when run with mvn install
  3. Use another image for the test as sometimes (for some images) Java8 and Java11 produce different base64 strings given the same input image.
  4. Improve the documentation to explain how this function works. In particular, this function only visualizes the first 4 bands regardless how many bands the input raster could have.

How was this patch tested?

Passed unit tests

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@jiayuasu jiayuasu added this to the sedona-1.5.0 milestone Sep 1, 2023
@jiayuasu jiayuasu merged commit d5ae944 into master Sep 1, 2023
39 checks passed
@jiayuasu jiayuasu deleted the bug-fix-base64 branch September 22, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant