[SEDONA-354] Add RS_SkewX and RS_SkewY #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Aug 11, 2023
docs/api/sql/Raster-operators.md
Outdated
| Spark SQL Exmaple: | ||
|
|
||
| ```sql | ||
| SELECT RS_SkewX(raster) FROM rasters |
There was a problem hiding this comment.
Can you use MakeEmptyRaster as the input?
|
@iGN5117 Can you please review? |
iGN5117
requested changes
Aug 11, 2023
| @Test | ||
| public void testSkewX() throws FactoryException { | ||
| GridCoverage2D emptyRaster = RasterConstructors.makeEmptyRaster(10, 2, 4, 6, 4, 1, 1, 2, 7, 0); | ||
| assertEquals(2, RasterAccessors.getSkewX(emptyRaster), 0.1d); |
There was a problem hiding this comment.
Please add tests testing the convenience constructor of MakeEmptyRaster with 0 skews
docs/api/sql/Raster-operators.md
Outdated
| Spark SQL Exmaple: | ||
|
|
||
| ```sql | ||
| SELECT RS_SkewY(raster) FROM rasters |
There was a problem hiding this comment.
Please use RS_MakeEmptyRaster in SQL examples so that the skew of the created raster in visible as well
iGN5117
approved these changes
Aug 11, 2023
jiayuasu
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.