[SEDONA-353] Add RS_BandNoDataValue #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DataValues from bands
# Conflicts: # docs/api/sql/Raster-operators.md
jiayuasu
requested changes
Aug 11, 2023
|
|
||
| @Test | ||
| public void testBandNoDataValueIllegalBand() throws FactoryException, IOException { | ||
| GridCoverage2D raster = rasterFromGeoTiff(resourceFolder + "raster/raster_with_no_data/test5.tiff"); |
There was a problem hiding this comment.
test5 has a file extension TIFF but you specified tiff here. Please change the file extension of the original image to tiff.
There was a problem hiding this comment.
That didn't seem to matter for my local tests. However, I've renamed the file extension to tiff and pushed now
jiayuasu
requested changes
Aug 11, 2023
jiayuasu
approved these changes
Aug 11, 2023
jiayuasu
requested changes
Aug 11, 2023
| @@ -0,0 +1,13 @@ | |||
| package org.apache.spark.sql.sedona_sql.expressions.raster | |||
There was a problem hiding this comment.
This file must have a Apache header.
There was a problem hiding this comment.
Sorry about that, pushed
jiayuasu
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.