[SEDONA-351] Support XYZM coordinate #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Aug 10, 2023
| @@ -254,7 +254,17 @@ public static Geometry transform(Geometry geometry, CoordinateReferenceSystem so | |||
| } | |||
|
|
|||
| public static int getDimension(Geometry geometry) { | |||
| return geometry.getCoordinate() != null && !java.lang.Double.isNaN(geometry.getCoordinate().getZ()) ? 3 : 2; | |||
| int dimension = 2; | |||
There was a problem hiding this comment.
This function is duplicate to nDims(): https://github.com/apache/sedona/blob/master/common/src/main/java/org/apache/sedona/common/Functions.java#L298
Please copy the logic of nDims here and let nDims function call this getDimension function.
jiayuasu
added
attention needed
affect public APIs
improvement
sedona-sql
sedona-common
and removed
sedona-sql
labels
jiayuasu
changed the title
iGN5117
reviewed
Aug 10, 2023
| @Test | ||
| public void asEWKT() throws Exception{ | ||
| Geometry geometry = GEOMETRY_FACTORY.createPoint(new Coordinate(1.0, 2.0)); | ||
| String actualResult = Functions.asEWKT(geometry); |
There was a problem hiding this comment.
Good idea.
I added SRID in them.
jiayuasu
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
GetDimension will support 2D and 3D, which will lead functions like ST_AsWKT ignore the M coordinate. After this PR is merged, M coordinate will be available in WKT format.
In short, current status of Sedona Input and Output ST functions are follows:
Sedona Jvm serializer will carry XYZM + SRID. So any ST functions in Sedona can access XYZM in the geometry type.
Shapely serializer does not support M so when deal with data created by Shapely, M is ignored.
How was this patch tested?
Comprehensive unit tests in sedona-common
Did this PR include necessary documentation updates?