Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-347] Centralize transform() usages #949

Merged
merged 44 commits into from
Aug 9, 2023

Conversation

iGN5117
Copy link
Contributor

@iGN5117 iGN5117 commented Aug 8, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • Centralize JTS.transform() usages

How was this patch tested?

  • Verified existing tests

Did this PR include necessary documentation updates?

  • No need to add documentation since this is a refactor

# Conflicts:
#	common/src/main/java/org/apache/sedona/common/raster/RasterAccessors.java
#	docs/api/sql/Raster-operators.md
#	sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala
#	sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/RasterAccessors.scala
# Conflicts:
#	sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala
#	sql/common/src/test/scala/org/apache/sedona/sql/rasteralgebraTest.scala
Impose assert on returned point's SRID
Refactor thrown exception to be IndexOutOfBounds
# Conflicts:
#	docs/api/sql/Raster-operators.md
#	sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala
#	sql/common/src/test/scala/org/apache/sedona/sql/rasteralgebraTest.scala
# Conflicts:
#	common/src/main/java/org/apache/sedona/common/raster/PixelFunctions.java
#	common/src/main/java/org/apache/sedona/common/raster/RasterAccessors.java
#	common/src/main/java/org/apache/sedona/common/utils/RasterUtils.java
#	common/src/test/java/org/apache/sedona/common/raster/RasterAccessorsTest.java
#	sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/RasterAccessors.scala
#	sql/common/src/test/scala/org/apache/sedona/sql/rasteralgebraTest.scala
…icates

# Conflicts:
#	common/src/main/java/org/apache/sedona/common/raster/RasterPredicates.java
#	sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala
#	sql/common/src/test/scala/org/apache/sedona/sql/rasteralgebraTest.scala
@jiayuasu
Copy link
Member

jiayuasu commented Aug 8, 2023

@iGN5117 In this PR, please only keep the change related to CRS transform.

@iGN5117
Copy link
Contributor Author

iGN5117 commented Aug 8, 2023

@iGN5117 In this PR, please only keep the change related to CRS transform.

@jiayuasu this PR actually only has CRS changes. However, it is back-merged with WorldToRaster PR for easy merging. Please re-check this once that PR is merged

@jiayuasu jiayuasu merged commit f0cee53 into apache:master Aug 9, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants