[SEDONA-346] Add WorldToRaster APIs #948
Conversation
# Conflicts: # common/src/main/java/org/apache/sedona/common/raster/RasterAccessors.java # docs/api/sql/Raster-operators.md # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/RasterAccessors.scala
# Conflicts: # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/test/scala/org/apache/sedona/sql/rasteralgebraTest.scala
…va test cases. Add example test case
…rm instead of envelope.
Impose assert on returned point's SRID
Refactor thrown exception to be IndexOutOfBounds
# Conflicts: # docs/api/sql/Raster-operators.md # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/test/scala/org/apache/sedona/sql/rasteralgebraTest.scala
Refactor API names to be clearer
# Conflicts: # common/src/main/java/org/apache/sedona/common/raster/PixelFunctions.java # common/src/main/java/org/apache/sedona/common/raster/RasterAccessors.java # common/src/main/java/org/apache/sedona/common/utils/RasterUtils.java # common/src/test/java/org/apache/sedona/common/raster/RasterAccessorsTest.java # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/RasterAccessors.scala # sql/common/src/test/scala/org/apache/sedona/sql/rasteralgebraTest.scala
| import org.opengis.referencing.operation.MathTransform; | ||
| import org.opengis.referencing.operation.TransformException; | ||
|
|
||
| import static org.apache.sedona.common.utils.RasterUtils.convertCRSIfNeeded; |
There was a problem hiding this comment.
This import is not correct. Please fix this.
There was a problem hiding this comment.
Refactored to import RasterUtils instead
| @@ -95,7 +100,7 @@ public static AffineTransform2D getAffineTransform(GridCoverage2D raster, PixelO | |||
| return (AffineTransform2D) crsTransform; | |||
| } | |||
|
|
|||
| public static Point2D getCornerCoordinates(GridCoverage2D raster, int colX, int rowY) throws TransformException { | |||
| public static Point2D getWorldCornerCoordinates(GridCoverage2D raster, int colX, int rowY) throws TransformException { | |||
There was a problem hiding this comment.
The problem might not be related to this PR. However, I think only getWorldCornerCoordinatesWithRangeCheck should be kept. I understand some PostGIS flavors do not perform range check. Do we actually support the computation of out of boundary raster coordinate?
There was a problem hiding this comment.
Yes we actually do support out of raster boundary coordinates as well. GridCoverage2D transform does not do any range checking on it own and hence its easy for us to support going out of bounds assuming the same skew and translate
| return RasterUtils.getWorldCornerCoordinates(raster, colX, rowY).getY(); | ||
| } | ||
|
|
||
| public static Geometry getGridCoord(GridCoverage2D raster, double longitude, double latitude) throws TransformException { |
There was a problem hiding this comment.
Given that the CRS transformation follows the lat/lon order, the parameters here are wrong. To avoid unnecessary complication, please call them X/Y, instead of longitude and latitude.
There was a problem hiding this comment.
Got it, changed lon and lat to x and y respectively
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.