[SEDONA-343] Add RS_Contains and RS_Within #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Aug 4, 2023
| return rasterGeometry.within(geometry); | ||
| } | ||
|
|
||
| private static Geometry convertCRSIfNeeded(Geometry geometry, CoordinateReferenceSystem rasterCRS) { |
There was a problem hiding this comment.
Can you re-use the code of ST_Transform?
There was a problem hiding this comment.
Is the order lon/lat or lat/lon?
|
|
||
| private static Geometry convertCRSIfNeeded(Geometry geometry, CoordinateReferenceSystem rasterCRS) { | ||
| int geomSRID = geometry.getSRID(); | ||
| if (rasterCRS != null && !(rasterCRS instanceof DefaultEngineeringCRS) && geomSRID > 0) { |
There was a problem hiding this comment.
Is the DefaultEngineeringCRS default or DefaultCartisian2D?
There was a problem hiding this comment.
DefaultEngineeringCRS is the default CRS, as also mentioned in makeEmptyRaster()
| GeometryFactory geometryFactory = new GeometryFactory(new PrecisionModel(), 4326); | ||
| Geometry geometry = geometryFactory.toGeometry(new Envelope(30, 60, 10, 50)); | ||
| GridCoverage2D raster = RasterConstructors.makeEmptyRaster(1, 20, 20, 32, 35, 1, -1, 0, 0, 4326); | ||
| geometry = JTS.transform(geometry, CRS.findMathTransform(raster.getCoordinateReferenceSystem(), CRS.decode("EPSG:3857"))); |
There was a problem hiding this comment.
Try to re-use the code from ST_Transform
jiayuasu
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.