[SEDONA-333] Implement ST_GeomFromEWKT #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Aug 1, 2023
| public void geomFromEWKT() throws ParseException { | ||
| assertNull(Constructors.geomFromEWKT(null)); | ||
|
|
||
| Geometry geom = Constructors.geomFromEWKT("POINT (1 1)"); |
There was a problem hiding this comment.
Please add one more test case SRID=4269;POINT (1 1) (no space between semicolon and the wkt string)
jiayuasu
requested changes
Aug 1, 2023
docs/api/flink/Constructor.md
Outdated
|
|
||
| SQL example: | ||
| ```sql | ||
| SELECT ST_GeomFromEWKT('SRID=4269;POINT(40.7128 -74.0060)') |
There was a problem hiding this comment.
Please print the result using ST_AsEWKT or ST_AsText . This will print SRID
| def test_st_geom_from_ewkt(self): | ||
| input_df = self.spark.createDataFrame([("SRID=4269;LineString(1 2, 3 4)",)], ["ewkt"]) | ||
| input_df.createOrReplaceTempView("input_ewkt") | ||
| line_df = self.spark.sql("select ST_LineFromText(ewkt) as geom from input_ewkt") |
There was a problem hiding this comment.
This test is not using ST_GeomFromEWKT
| @@ -94,6 +94,13 @@ class dataFrameAPITestScala extends TestBaseScala { | |||
| assert(actualResult.getSRID == 4326) | |||
| } | |||
|
|
|||
| it("passed st_geomfromewkt") { | |||
| val df = sparkSession.sql("SELECT ST_GeomFromEWKT('SRID=4269;POINT(0.0 1.0)')") | |||
There was a problem hiding this comment.
This test didn't test the DataFrame API
| @@ -132,6 +133,17 @@ def ST_GeomFromWKT(wkt: ColumnOrName) -> Column: | |||
| """ | |||
| return _call_constructor_function("ST_GeomFromWKT", wkt) | |||
|
|
|||
| @validate_argument_types | |||
| def ST_GeomFromEWKT(ewkt: ColumnOrName) -> Column: | |||
jiayuasu
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Add ST_GeomFromEWKTto sedona-common, sedona-sql, sedona-flink, and the dataframe/python API.
How was this patch tested?
Did this PR include necessary documentation updates?