[SEDONA-336] Add RS_UpperLeftX and RS_UpperLeftY #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGN5117
requested changes
Jul 31, 2023
| val df = sparkSession.read.format("binaryFile").load(resourceFolder + "raster/test1.tiff") | ||
| val result = df.selectExpr("RS_UpperLeftX(RS_FromGeoTiff(content))").first().getDouble(0) | ||
| val expected: Double = -1.3095817809482181E7 | ||
| assertEquals(expected, result, 1e12) |
There was a problem hiding this comment.
This will allow a difference of 10^12 while asserting equals. I think you mean 1e-12 which is 10^-12
There was a problem hiding this comment.
Thank you for pointing it out.
| val df = sparkSession.read.format("binaryFile").load(resourceFolder + "raster/test1.tiff") | ||
| val result = df.selectExpr("RS_UpperLeftY(RS_FromGeoTiff(content))").first().getDouble(0) | ||
| val expected: Double = 4021262.7487925636 | ||
| assertEquals(expected, result, 1e8) |
There was a problem hiding this comment.
Same here, I believe this is supposed to be 1e-8
jiayuasu
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.