Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-330] Fix SedonaPyDeck bugs #922

Merged

Conversation

iGN5117
Copy link
Contributor

@iGN5117 iGN5117 commented Jul 26, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • Fix bugs in SedonaPyDeck

How was this patch tested?

  • Rendered test maps

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

iGN5117 added 30 commits July 3, 2023 20:33
Added a utilities file that hardcodes map config
…github.com/iGN5117/sedona into develop_Nilesh_1.5.0_NotebookVisualization

# Conflicts:
#	binder/ApacheSedonaSQL_SpatialJoin_AirportsPerCountry.ipynb
…ization

# Conflicts:
#	binder/ApacheSedonaSQL_SpatialJoin_AirportsPerCountry.ipynb
Added comments and documentation on using SedonaKepler
Added keplergl to sedona/python pipfile
Added SedonaKepler import to SedonaContext init
Added basic test cases for map created by SedonaKepler
Reverted jupyter notebook example to sedona 1.4.1 compatible example
Removed unnecessary init.py in python
Refactored method names to follow python convention
Add comprehensive test cases for SedonaKepler
…on 3.7

Updated tests
Refactored naming schemes
Refactor SedonaKepler to remove need for geometry_col in exposed APIs
Add pydeck to Pipfile
Add google buildings and chicago crimes dataset
Add tests for SedonaPyDeck
Update documentation and tests
…ization

# Conflicts:
#	docs/tutorial/sql.md
#	python/Pipfile
#	python/sedona/maps/SedonaKepler.py
#	python/sedona/maps/__init__.py
#	python/sedona/spark/__init__.py
#	python/tests/maps/test_sedonakepler_visualization.py
Update SedonaPyDeck scatterplot to add more possible customizations
Updated documentation
Added Chicago Crimes dataset terms of use and referenced them in licenses file
Referenced CC by 4.0 for Google Buildings Dataset in licenses file
2) decrease opacity for geometry_map
3) change extractCoordinate call to iterative instead of recursive
…ization

# Conflicts:
#	python/sedona/maps/SedonaMapUtils.py
#	python/sedona/maps/SedonaPyDeck.py
@jiayuasu jiayuasu added this to the sedona-1.5.0 milestone Jul 26, 2023
@jiayuasu jiayuasu changed the title [SEDONA-330] FIx SedonaPyDeck bugs [SEDONA-330] Fix SedonaPyDeck bugs Jul 26, 2023
@jiayuasu
Copy link
Member

@iGN5117 Please fix the failed CI

@jiayuasu jiayuasu merged commit d1addae into apache:master Jul 27, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants