Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SEDONA-326] Improve raster algebra functions: RS_Array and RS_MultiplyFactor #907

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[SEDONA-326] Improve raster algebra functions: RS_Array and RS_MultiplyFactor #907

merged 1 commit into from
Jul 18, 2023

Conversation

Kontinuation
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

Yes, SEDONA-326

What changes were proposed in this PR?

Make RS_Array and RS_MultiplyFactor easier to use.

  • RS_Array automatically casts the initial value to double. Now we can safe guard RS_Divide using 
    RS_Divide(band_nir, RS_LogicalOver(band_red, RS_Array(array_size(band_red), 1e-12)))
  • RS_MultiplyFactor takes double factors.

How was this patch tested?

Added new unit tests.

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@Kontinuation Kontinuation marked this pull request as ready for review July 18, 2023 09:44
@jiayuasu jiayuasu added this to the sedona-1.5.0 milestone Jul 18, 2023
@jiayuasu jiayuasu merged commit d1f8b0e into apache:master Jul 18, 2023
29 of 39 checks passed
@Kontinuation Kontinuation deleted the raster-algebra-improvements branch August 23, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiayuasu jiayuasu jiayuasu approved these changes

Assignees
No one assigned
Labels
affect public APIs improvement sedona-common sedona-sql
Projects
None yet
Milestone
sedona-1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kontinuation @jiayuasu