Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-303] Port all Sedona Spark function to Sedona Flink -- ST_Intersection_Aggr #905

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

yyy1000
Copy link
Contributor

@yyy1000 yyy1000 commented Jul 17, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Port missing aggregation including
{ST_Intersection_Aggr}
to sedona-flink.

How was this patch tested?

  1. Integration unit tests in sedona-flink.

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

Table polygonTable = createPolygonOverlappingTable(testDataSize);
Table result = polygonTable.select(call("ST_Intersection_Aggr", $(polygonColNames[0])));
Row last = last(result);
assertEquals("LINESTRING EMPTY", last.getField(0).toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please come up with a test case that generates a non-empty result. @yyy1000

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jiayuasu jiayuasu merged commit 8d7ca37 into apache:master Jul 17, 2023
29 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants