Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-323] Add keplergl wrapper #898

Merged

Conversation

iGN5117
Copy link
Contributor

@iGN5117 iGN5117 commented Jul 11, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • This PR adds SedonaKepler in sedona.maps. SedonaKepler is a wrapper for creating keplergl maps in sedona.

How was this patch tested?

  • Refactored notebook example to include SedonaKepler, and verified correct map rendering.
  • Ran basic test case testing SedonaKepler map object and keplergl map object.

Did this PR include necessary documentation updates?

  • Yes, I have added documentation for using SedonaKepler.

iGN5117 added 16 commits July 3, 2023 20:33
Added a utilities file that hardcodes map config
…github.com/iGN5117/sedona into develop_Nilesh_1.5.0_NotebookVisualization

# Conflicts:
#	binder/ApacheSedonaSQL_SpatialJoin_AirportsPerCountry.ipynb
…ization

# Conflicts:
#	binder/ApacheSedonaSQL_SpatialJoin_AirportsPerCountry.ipynb
Added comments and documentation on using SedonaKepler
Added keplergl to sedona/python pipfile
Added SedonaKepler import to SedonaContext init
Added basic test cases for map created by SedonaKepler
Reverted jupyter notebook example to sedona 1.4.1 compatible example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this test to python/tests/maps/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed as the Python folder per se is not a package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not intended to be added, removed this.

python/sedona/maps/SedonaKepler.py Show resolved Hide resolved
Removed unnecessary init.py in python
Refactored method names to follow python convention
### Setting a config via the map
A map rendered by accessing the map object created by SedonaKepler includes a config panel which can be used to customize the map

<img src="../../image/sedona_customization.gif" width="1000">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iGN5117 This doc references to this image but this image was not committed together with this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, pushed the gif

@jiayuasu jiayuasu merged commit d4d0110 into apache:master Jul 18, 2023
29 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants