[SEDONA-313] Refactor ST_Affine #875

iGN5117 · 2023-06-27T21:00:06Z

Did you read the Contributor Guide?

Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-313. The PR name follows the format [SEDONA-XXX] my subject.

What changes were proposed in this PR?

Refactor full form signature of ST_Affine to make it same as PostGIS

How was this patch tested?

Updated tests after comparing with PostGIS and made sure they pass.

Did this PR include necessary documentation updates?

Yes, I am adding a new API. I am using the 1.5.0 in since vX.Y.Z format.

This reverts commit c7f6236.

This reverts commit 85ae113.

Removed note/tip block elements that caused numbering to be reset

…entation_update_Nilesh

into develop_Nilesh_1.4.0

Changed generic Exception to IllegalArgumentException in ST_NumPoints implementation and its corresponding test

# Conflicts: # common/src/main/java/org/apache/sedona/common/Functions.java # common/src/test/java/org/apache/sedona/common/FunctionsTest.java # flink/src/main/java/org/apache/sedona/flink/Catalog.java # flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java # flink/src/test/java/org/apache/sedona/flink/FunctionTest.java # python/sedona/sql/st_functions.py # python/tests/sql/test_function.py # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala # sql/common/src/test/scala/org/apache/sedona/sql/dataFrameAPITestScala.scala # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala

Refactored function name Made java tests more comprehensive by checking both nDims and WKT of returned geometry Added more test cases in scala test cases Updated documentation with empty geometry case and more examples

…ut. Added a note explaining the same

Update java/scala test execution

…GN5117/sedona into develop_Nilesh_1.4.1_Translate # Conflicts: # common/src/main/java/org/apache/sedona/common/Functions.java # common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java # common/src/test/java/org/apache/sedona/common/FunctionsTest.java # flink/src/main/java/org/apache/sedona/flink/Catalog.java # flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java # flink/src/test/java/org/apache/sedona/flink/FunctionTest.java # python/sedona/sql/st_functions.py # python/tests/sql/test_function.py # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala # sql/common/src/test/scala/org/apache/sedona/sql/dataFrameAPITestScala.scala # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala

Added geom collection test cases for force3D

# Conflicts: # common/src/main/java/org/apache/sedona/common/Functions.java # common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java # common/src/test/java/org/apache/sedona/common/FunctionsTest.java # flink/src/main/java/org/apache/sedona/flink/Catalog.java # flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java # python/sedona/sql/st_functions.py # python/tests/sql/test_function.py # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala # sql/common/src/test/scala/org/apache/sedona/sql/dataFrameAPITestScala.scala # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala

# Conflicts: # common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java # common/src/test/java/org/apache/sedona/common/FunctionsTest.java # flink/src/main/java/org/apache/sedona/flink/Catalog.java # flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java # python/sedona/sql/st_functions.py # python/tests/sql/test_function.py # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/NullSafeExpressions.scala # sql/common/src/test/scala/org/apache/sedona/sql/dataFrameAPITestScala.scala # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala

# Conflicts: # common/src/main/java/org/apache/sedona/common/Functions.java # common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java # common/src/test/java/org/apache/sedona/common/FunctionsTest.java # flink/src/main/java/org/apache/sedona/flink/Catalog.java # python/sedona/sql/st_functions.py # python/tests/sql/test_function.py # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala # sql/common/src/test/scala/org/apache/sedona/sql/dataFrameAPITestScala.scala # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala

Refactor affine to support signature like PostGIS

iGN5117 added 30 commits June 6, 2023 13:29

Remove prebuild_index config from search plugin

85ae113

Update compile the code documentation for sedona

8e829fe

approximate float comparisons in python test cases

4bcf99c

Update compile the code documentation for sedona

c7f6236

Remove prebuild_index config from search plugin

ceed7a4

Revert "Update compile the code documentation for sedona"

15c6255

This reverts commit c7f6236.

Revert "Remove prebuild_index config from search plugin"

471e281

This reverts commit 85ae113.

FIxed incorrect indentation

2a5a6d8

Addressed PR comments for documentation changes

6e9883d

Removed note/tip block elements that caused numbering to be reset

Merge branch 'master' of https://github.com/iGN5117/sedona into docum…

e66895e

…entation_update_Nilesh

Add ST_NumPoints

cf7e78d

Update available version to 1.4.1 in documentation

fc23fc9

Merge branch 'apache:master' into develop_Nilesh_1.4.0

fea1daa

Fix failing scala test case

816e4ed

Merge branch 'develop_Nilesh_1.4.0' of https://github.com/iGN5117/sedona

472c383

into develop_Nilesh_1.4.0

Updated documentation to include negative flow.

471a87e

Changed generic Exception to IllegalArgumentException in ST_NumPoints implementation and its corresponding test

Removed Spark SQL from flink documentation

b33499d

Add ST_Force3D to sedona

0d68337

Updated force3D logic to handle empty geometries

da0314a

Refactored function name Made java tests more comprehensive by checking both nDims and WKT of returned geometry Added more test cases in scala test cases Updated documentation with empty geometry case and more examples

Updated force3D dataframe test

020e9b9

fix error in test case

86de054

Updated documentation for Force3D to include Z format WKT in the outp…

307c060

…ut. Added a note explaining the same

Added default zValue test case in sedona flink

dbab04c

Added default zValue dataframe test case

c0eb8bc

Added default zValue scala test case

479b264

fix dataframe testcase

641d2d9

Addressed PR comments

c2e27d8

Merge branch 'develop_Nilesh_1.4.0' into documentation_update_Nilesh

4fa254d

Update community/develop to include steps to run python test cases.

9815161

Update java/scala test execution

iGN5117 added 17 commits June 12, 2023 13:20

Merge branch 'apache:master' into documentation_update_Nilesh

5bdf476

Add ST_NRings

b5cf30c

Add ST_Translate

b89cec1

Updated GeomUtils to remove redundant geom return type

ece4802

Simplified ST_Translate implementation, updated test cases and docs

78be0f1

Added geom collection test cases for force3D

Updated tests for Translate

cd12ce2

temp affine commit

19016ae

java, scala test cases, documentation updates

e4674fc

Back merged with st_nrings

ee59846

back merged with develop documentation update

e6ca70e

updated python and dataframe integration test

17b25b1

remove NullSafeExpressions from common

b44a1ad

Backmerge with master

d93f65c

Refactor affine to support signature like PostGIS

jiayuasu approved these changes Jun 28, 2023

View reviewed changes

jiayuasu added this to the sedona-1.5.0 milestone Jun 28, 2023

jiayuasu added improvement sedona-sql sedona-python sedona-common labels Jun 28, 2023

jiayuasu merged commit e6f112c into apache:master Jun 28, 2023
39 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SEDONA-313] Refactor ST_Affine #875

[SEDONA-313] Refactor ST_Affine #875

iGN5117 commented Jun 27, 2023

[SEDONA-313] Refactor ST_Affine #875

[SEDONA-313] Refactor ST_Affine #875

Conversation

iGN5117 commented Jun 27, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

How was this patch tested?

Did this PR include necessary documentation updates?