[SEDONA-294 | SEDONA-310] Add ST_Angle and ST_Degrees to sedona #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # common/src/main/java/org/apache/sedona/common/Functions.java # common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java # common/src/test/java/org/apache/sedona/common/FunctionsTest.java # flink/src/main/java/org/apache/sedona/flink/Catalog.java # flink/src/test/java/org/apache/sedona/flink/FunctionTest.java # python/sedona/sql/st_functions.py # python/tests/sql/test_dataframe_api.py # python/tests/sql/test_function.py # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala # sql/common/src/test/scala/org/apache/sedona/sql/dataFrameAPITestScala.scala # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala
# Conflicts: # common/src/test/java/org/apache/sedona/common/FunctionsTest.java # flink/src/main/java/org/apache/sedona/flink/Catalog.java # python/sedona/sql/st_functions.py # python/tests/sql/test_function.py # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala # sql/common/src/test/scala/org/apache/sedona/sql/dataFrameAPITestScala.scala # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala
…_Angle # Conflicts: # common/src/main/java/org/apache/sedona/common/Functions.java # common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java # common/src/test/java/org/apache/sedona/common/FunctionsTest.java # docs/api/flink/Function.md # docs/api/sql/Function.md # flink/src/main/java/org/apache/sedona/flink/Catalog.java # flink/src/test/java/org/apache/sedona/flink/FunctionTest.java # python/sedona/sql/st_functions.py # python/tests/sql/test_dataframe_api.py # python/tests/sql/test_function.py # sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/NullSafeExpressions.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala # sql/common/src/test/scala/org/apache/sedona/sql/dataFrameAPITestScala.scala # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala
jiayuasu
reviewed
Jun 26, 2023
| @@ -481,6 +515,11 @@ public static void affineGeom(Geometry geometry, Double a, Double b, Double d, D | |||
| geometry.geometryChanged(); | |||
| } | |||
|
|
|||
| public static double getFrechetDistance(Geometry g1, Geometry g2) { | |||
There was a problem hiding this comment.
Why is this PR adding getFrechetDistance?
# Conflicts: # common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java # python/sedona/sql/st_functions.py # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala
|
@iGN5117 Please refer to Kristin's latest PR for overloaded functions and fix your PR accordingly: https://github.com/apache/sedona/pull/874/files |
# Conflicts: # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/InferredExpression.scala # sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala
|
@iGN5117 Please this accordingly |
# Conflicts: # common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java # sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/InferredExpression.scala
jiayuasu
requested changes
Jun 29, 2023
docs/api/flink/Function.md
Outdated
| Computes the angle formed by vectors S1 - E1 and S2 - E2, where S and E denote start and end points respectively | ||
|
|
||
| !!!Note | ||
| If any other geometry type is provided, ST_Angle throws an IllegalArgumentException. |
There was a problem hiding this comment.
This needs to have indent otherwise mkdocs-materials cannot render it properly
There was a problem hiding this comment.
Please fix this issue in both Spark and Flink docs
There was a problem hiding this comment.
Sorry about that, this got misplaced while resolving conflicts. This is now fixed
jiayuasu
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.