Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-291] Python test cases failing due to exact equality comparisons between floats #850

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

iGN5117
Copy link
Contributor

@iGN5117 iGN5117 commented Jun 6, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • Added approximate float comparisons with relative tolerance of 1e-9 in python test cases to prevent them from failing.

How was this patch tested?

  • Ran all python test cases post code changes to ensure that they pass.

Did this PR include necessary documentation updates?

  • No documentation updates needed

python/sedona/core/geom/envelope.py Outdated Show resolved Hide resolved
docs/setup/compile.md Outdated Show resolved Hide resolved
docs/setup/compile.md Outdated Show resolved Hide resolved
@jiayuasu jiayuasu added this to the sedona-1.4.1 milestone Jun 7, 2023
@iGN5117 iGN5117 changed the title Develop nilesh 1.4.0 [SEDONA-291] Python test cases failing due to exact equality comparisons between floats Jun 7, 2023
@jiayuasu jiayuasu merged commit 1dd2321 into apache:master Jun 7, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants