[SEDONA-280] Add ST_GeometricMedian #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
May 11, 2023
sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala
Show resolved
Hide resolved
Updated docs Added check for geometry type
Added test cases
jiayuasu
requested changes
May 16, 2023
| ("'MULTIPOINT ((0 0), (10 1), (5 1), (20 20))'", 1e-15) -> "'POINT (5 1)'", | ||
| ("'MULTIPOINT ((0 -1), (0 0), (0 0), (0 1))'", 1e-6) -> "'POINT (0 0)'", | ||
| ("'POINT (7 6)'", 1e-6) -> "'POINT (7 6)'", | ||
| ("'MULTIPOINT ((12 5),(62 7),(100 -1),(100 -5),(10 20),(105 -5))'", 1e-15) -> "'POINT(84.21672412761632 0.1351485929395439)'", |
There was a problem hiding this comment.
Scala compilation is failed here: error file=/home/runner/work/sedona/sedona/sql/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala message=expected start of definition, but was Token(VAL,val,85798,val)
This is likely caused by this comma ,. Please remove the last comma which is not needed.
Remove coma breaking Scala compilation
Fix data type
Rename parameters
jiayuasu
requested changes
May 17, 2023
| @@ -81,6 +81,7 @@ | |||
| (stf.ST_ExteriorRing, ("geom",), "triangle_geom", "", "LINESTRING (0 0, 1 0, 1 1, 0 0)"), | |||
| (stf.ST_FlipCoordinates, ("point",), "point_geom", "", "POINT (1 0)"), | |||
| (stf.ST_Force_2D, ("point",), "point_geom", "", "POINT (0 1)"), | |||
| (stf.ST_GeometricMedian, ("multipoint_geom",), "point_geom", "", "POINT(22.500002656424286 21.250001168173426)"), | |||
There was a problem hiding this comment.
I believe this line should be
("multipoint",), "multipoint_geom"
Then it will fix the failed Python test case
Fix python test
jiayuasu
requested changes
May 18, 2023
| @@ -81,6 +81,7 @@ | |||
| (stf.ST_ExteriorRing, ("geom",), "triangle_geom", "", "LINESTRING (0 0, 1 0, 1 1, 0 0)"), | |||
| (stf.ST_FlipCoordinates, ("point",), "point_geom", "", "POINT (1 0)"), | |||
| (stf.ST_Force_2D, ("point",), "point_geom", "", "POINT (0 1)"), | |||
| (stf.ST_GeometricMedian, ("multipoint",), "multipoint_geom", "", "POINT(22.500002656424286 21.250001168173426)"), | |||
There was a problem hiding this comment.
OK. There should be a space between POINT and (. It should be POINT (
There was a problem hiding this comment.
@jiayuasu Yeah, I figured. Should have installed python for testing. Thanks for quick reviews and your help.
Fix python test - remove space
jiayuasu
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Port of ST_GeometricMean from PostGIS
How was this patch tested?
Test cases and running in internal environment. Checking results against PostGIS.
Did this PR include necessary documentation updates?
Yes