-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-269] Add Raster data source and RS_AsGeoTiff and RS_AsArcGrid #828
Conversation
@umartin Hi Martin, the design of this PR is slightly different from your initial proposal in https://issues.apache.org/jira/browse/SEDONA-269 . This design does not need |
@jiayuasu I can take a look at the R part |
Hi, I would prefer a plain binary data source and separate RS_AsXXX functions. There are several benefits to separating the raster formats and the data source
|
@umartin Thank you for the great suggestion. I will make changes accordingly and add RS_AsXXX as well. @gregleleu Thank you for your help! Please wait for now. I will make some changes based on Martin's comment, then you can add new functions to Sedona R :-) |
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-269] my subject
.What changes were proposed in this PR?
raster
designed for writing rastersfileExtension
: this can be any file extension string. If not given,.tiff
pathField
which indicates each raster file name. If not given, it will use UUID as the name of each rasterrasterField
: the raster field column name, if you have multiple binary type columns in a DataFrame.io
toio.raster
.The future plan of Sedona raster data sources:
geotiff
data source in1.4.1
(around 1 month from now) as it is not convenient for our upcoming raster operations. I plan to completely remove it in1.5.0
(I guess around 4 months from now). To make this happen, a few other PRs that bridge Array[Double] and RasterUDT must be made. My idea is to completely get rid of Array[Double] and migrate Array[Double] based RS functions to RasterUDT environment. But let's see.binaryFile
data source andRS_FromXXX
for reading rasters(2)RS_AsXXX
andraster
data source for writing rasters. This gives us much more flexibility and introduces opportunities for brining a flurry of new raster functions.TODO:
Sedona R needs corresponding data_interface
spark_write_raster
How was this patch tested?
Added new unit tests.
Did this PR include necessary documentation updates?
vX.Y.Z
format.