[SEDONA-274] move sql function collectionExtract and collect to common #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
reviewed
Apr 24, 2023
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala
Show resolved
Hide resolved
jiayuasu
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
move the implementation of the following funcs to to sedona common
ST_Collect
ST_CollectionExtract
Move ST_CollectionExtract to InferedTypeBinaryExpression
ST_Collect can't be moved to InferedTypeBinaryExpression because it takes dynamic parameters.
How was this patch tested?
Update the existing test cases to execute based on the java implementation
Did this PR include necessary documentation updates?