Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-265] Migrate all ST functions to Sedona Inferred Expressions #820

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

zongsizhang
Copy link
Contributor

@zongsizhang zongsizhang commented Apr 18, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Transplant all the sql st funcions' implementation to sedona-common to allow added to flink and other computation engines.
Migrate the expressions to inferred typed expressions. Except following

  • ST_SubDivideExplode <== explode method 1 -> N
  • ST_MinimumBoundingRadius <== result in 2 columns
  • St_geomfromwkb <== accept 2 types of argument, require overloading
  • Predicates <== spatial join detector requires implementation of ST_Predicate class

How was this patch tested?

Update the existing test cases to execute based on the java implementation

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu changed the title move expressions to inferred typed, and implementation to commons [SEDONA-265] Migrate all ST functions to Sedona Inferred Expressions Apr 18, 2023
@jiayuasu
Copy link
Member

@zongsizhang This LGTM. Can you list out the outlier functions that cannot be migrated to Inferred Expressions?

@jiayuasu jiayuasu added this to the sedona-1.4.1 milestone Apr 19, 2023
@jiayuasu jiayuasu merged commit 7044c0c into master Apr 19, 2023
@jiayuasu jiayuasu deleted the fix/move-sql-funcitons-implementation-to-commons branch April 30, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants