Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-274] transplant FormatUtils to sedona-common #819

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

zongsizhang
Copy link
Contributor

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Transplant the sedona-core FormatUtils class and corresponding enum classes to sedona-common. To enable us move some sql ST constructor functions implementation to sedona-common package. This will allow us to add on the ST functions to other computation engine easily

How was this patch tested?

Update the existing test cases to execute based on the java implementation

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu
Copy link
Member

This one LGTM but please fix the failed CI.

@jiayuasu jiayuasu merged commit 1b73ccf into master Apr 18, 2023
@jiayuasu jiayuasu deleted the fix/move-formatutils-from-core-to-common branch April 18, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants