Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-260] Don't swap the left and right relations of spatial joins #795

Merged
merged 2 commits into from
Mar 12, 2023

Conversation

Kontinuation
Copy link
Member

@Kontinuation Kontinuation commented Mar 12, 2023

Notice

This patch depends on #796.

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Do not automatically swap the left and right relations when doing spatial joins, since it may cause confusion when the user wants to configure the partition and index-build side of the join.

How was this patch tested?

Tested using existing tests in SpatialJoinSuite.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@Kontinuation Kontinuation changed the title [SEDONA-260] Don't swap the left and right relations of spatial joins WIP [SEDONA-260] Don't swap the left and right relations of spatial joins Mar 12, 2023
@Kontinuation Kontinuation changed the title WIP [SEDONA-260] Don't swap the left and right relations of spatial joins WIP: [SEDONA-260] Don't swap the left and right relations of spatial joins Mar 12, 2023
@Kontinuation Kontinuation marked this pull request as draft March 12, 2023 05:22
@jiayuasu
Copy link
Member

This PR changes the behavior of Sedona Conf. We'd better put it in the upcoming Sedona 1.4.0, a major version that allows behavior change.

…om the right-side relation when running broadcast join.
…rse the spatial predicate instead.

Allow distance expression in distance join to reference attributes from the right-side relation when running broadcast join.
@Kontinuation Kontinuation changed the title WIP: [SEDONA-260] Don't swap the left and right relations of spatial joins [SEDONA-260] Don't swap the left and right relations of spatial joins Mar 12, 2023
@Kontinuation Kontinuation marked this pull request as ready for review March 12, 2023 10:26
@jiayuasu jiayuasu merged commit 5121743 into apache:master Mar 12, 2023
@Kontinuation Kontinuation deleted the sql-join-left-right branch August 23, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants