-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-229] Fix Linter Issues in Viz #791
Conversation
This doesn't fix all linter issues in viz. There will be several follow up PRs to address issues that require real code/config changes. Is this level of granularity ok? I'm trying to avoid pushing too large of code changes, but I also don't want to annoy you with a bunch of PRs. |
@douglasdennis This is perfectly fine. However, I wonder if scala has something similar to https://code.revelc.net/formatter-maven-plugin/ in the Java world. This will automatically fix styling issues instead of manually doing the job. |
@jiayuasu I found scalafmt (https://scalameta.org/scalafmt/). It looks like spotless (https://github.com/diffplug/spotless/tree/main/plugin-maven) uses it to handle Scala code as a maven plugin. I can explore that for handling the formatting related linter messages. Would there be any interest to add this as a check to the build process? |
@douglasdennis I think spotless is nice. Let's have it in Sedona. I think we should put it in the build process. Should we allow the build process automatically fix the format, or let the build process fail and we manually call I kind of prefer the auto fix. |
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
What changes were proposed in this PR?
This PR addresses several linter issues in the sedona viz module. All of the fixes for these issues involve no real structural code changes, just formatting and being more explicit with imports. The types of changes in this PR:
How was this patch tested?
Standard build process with unit tests.
Did this PR include necessary documentation updates?