Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Upgrade GitHub Action to Ubuntu 22.04 #790

Merged
merged 5 commits into from
Mar 7, 2023

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Mar 6, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No, this is a documentation update. The PR name follows the format [DOCS] my subject.

What changes were proposed in this PR?

Upgrade the CI to use Ubuntu 22.04

How was this patch tested?

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu changed the title [DOCS] Upgrade to 22.04 and publish jars upon commit [DOCS] Upgrade GitHub Action to Ubuntu 22.04 and publish jars upon commit Mar 6, 2023
@jiayuasu jiayuasu changed the title [DOCS] Upgrade GitHub Action to Ubuntu 22.04 and publish jars upon commit [DOCS] Upgrade GitHub Action to Ubuntu 22.04 Mar 6, 2023
@jiayuasu
Copy link
Member Author

jiayuasu commented Mar 8, 2023

@gregleleu With this PR got merged, the java workflow will generate jars that include sedona-spark-shaded. You can now use it. However, regarding auto create releases per commit, we need to add additional third-party GitHub action to the workflow (https://github.com/marvinpinto/action-automatic-releases).

ASF currently does not allow unauthorized third-party GitHub actions. Therefore, we have to copy the third-party actions source code to Sedona repo under .github/actions/xxx. This is a bit complicated.

@gregleleu
Copy link
Contributor

I had done a bit of research also on my end and I figured this would be the case with ASF: the GitHub CLI should be pre-installed on all runners and should be able to create/update the release without needing third-party actions; see:

You might have to create a release the first time and then update it (or test for existence and create/update).

@jiayuasu jiayuasu deleted the upgrade-github-actions branch March 8, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants