Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-229] Fix Linter Messages in Python Adapter #789

Merged

Conversation

douglasdennis
Copy link
Contributor

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

This PR addresses the linter messages that were printing for the python adapter module. There were 3 of them:

  • Missing newlines at end of files.
  • Long line: an import line.
  • Wildcard imports: The only ones in this module were for implicits/converters. I added an ignore regex to the scalastyle check so that these types of wildcard imports would be ignored (it seems that wildcard import is the correct way to import implicits).

How was this patch tested?

Standard build run. No structural changes were made to the code.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@douglasdennis
Copy link
Contributor Author

@jiayuasu I'm not sure why the build is canceling. I would think it is unrelated to this PR, but if I'm missing something then please let me know.

@jiayuasu
Copy link
Member

jiayuasu commented Mar 6, 2023

@douglasdennis I think GitHub action ran into some internal issues. I wasn't able to restart the jobs. Let's wait for a few more hours. Hopefully GitHub can address this issue soon.

@jiayuasu
Copy link
Member

jiayuasu commented Mar 6, 2023

@douglasdennis OK. This is an intended warning from GitHub Action to remind us upgrade Ubuntu 18.04: actions/runner-images#6002

Will create a PR now to fix the GitHub Actions

@gregleleu
Copy link
Contributor

@jiayuasu I tested the R build action with 22.04 and it worked fine, so you should be able to just replace 18.04 with 22.04 in that one

@jiayuasu jiayuasu merged commit e292a9e into apache:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants