-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-242] R: Update dependencies + fix failing test #769
Conversation
The R build has failed: it's not the old error -> all the tests failed because Spark did not start. |
@gregleleu I also don't know what happened... |
@gregleleu It is weird that the exact same CI passed on my fork: jiayuasu#1 |
@jiayuasu The logs were showing an issue with the jts core jars (between version 1.18.0 and 1.18.1) maybe it's an issue with resolving dependencies and/or cached versions? Also, should I bump the dependencies to the 1.4.0 versions? Eg 1.19.0 for jts core |
@gregleleu Yes, please bump the dependencies version to the 1.4.0 version. Thanks for reminding me about the cache issue. The CI passed after I cleaned up the cache! |
Bumped org.locationtech.jts:jts-core dependency to 1.19.0
Bumped dependencies. Just to be clear, the R package now loads:
It does not handle any of the exclusions that are in the POM. ("1.3.1-incubating" are replaced by "1.4.0-SNAPHSOT" for CICD by the overwrite mechanism included in the package through the SEDONA_JAR_FILES env variable) |
What changes were proposed in this PR?
Updating dependencies in R package
How was this patch tested?
Ran R tests
Did this PR include necessary documentation updates?