Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-242] R: Update dependencies + fix failing test #769

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

gregleleu
Copy link
Contributor

What changes were proposed in this PR?

Updating dependencies in R package

How was this patch tested?

Ran R tests

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@gregleleu gregleleu changed the title Update dependencies + fix failing test R: Update dependencies + fix failing test Feb 14, 2023
@gregleleu
Copy link
Contributor Author

The R build has failed: it's not the old error -> all the tests failed because Spark did not start.
I am unable to reproduce on my computer

@jiayuasu
Copy link
Member

@gregleleu I also don't know what happened...

@jiayuasu
Copy link
Member

jiayuasu commented Feb 15, 2023

@gregleleu It is weird that the exact same CI passed on my fork: jiayuasu#1

@gregleleu
Copy link
Contributor Author

@jiayuasu The logs were showing an issue with the jts core jars (between version 1.18.0 and 1.18.1) maybe it's an issue with resolving dependencies and/or cached versions?

Also, should I bump the dependencies to the 1.4.0 versions? Eg 1.19.0 for jts core

@jiayuasu
Copy link
Member

@gregleleu Yes, please bump the dependencies version to the 1.4.0 version. Thanks for reminding me about the cache issue. The CI passed after I cleaned up the cache!

@jiayuasu jiayuasu changed the title R: Update dependencies + fix failing test [DOCS] Update dependencies + fix failing test Feb 15, 2023
@jiayuasu jiayuasu added the docs label Feb 15, 2023
@jiayuasu jiayuasu changed the title [DOCS] Update dependencies + fix failing test [DOCS] R: Update dependencies + fix failing test Feb 15, 2023
@jiayuasu jiayuasu changed the title [DOCS] R: Update dependencies + fix failing test [SEDONA-242] R: Update dependencies + fix failing test Feb 15, 2023
Bumped org.locationtech.jts:jts-core dependency to 1.19.0
@gregleleu
Copy link
Contributor Author

gregleleu commented Feb 15, 2023

Bumped dependencies.

Just to be clear, the R package now loads:

  • org.apache.sedona:sedona-core-3.0_2.12:1.3.1-incubating
  • org.apache.sedona:sedona-sql-3.0_2.12:1.3.1-incubating
  • org.apache.sedona:sedona-viz-3.0_2.12:1.3.1-incubating
  • org.datasyslab:geotools-wrapper:1.3.0-27.2
  • edu.ucar:cdm-core:5.4.2
  • org.locationtech.jts:jts-core:1.19.0
  • org.wololo:jts2geojson:0.16.1

It does not handle any of the exclusions that are in the POM.

("1.3.1-incubating" are replaced by "1.4.0-SNAPHSOT" for CICD by the overwrite mechanism included in the package through the SEDONA_JAR_FILES env variable)

@jiayuasu jiayuasu added this to the sedona-1.4.0 milestone Feb 15, 2023
@jiayuasu jiayuasu merged commit 5a91619 into apache:master Feb 15, 2023
@gregleleu gregleleu deleted the r-dependencies branch March 4, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants