[SEDONA-207] Fix ambiguity of empty multi-geometries and multi geometries containing only empty geometries #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng only empty geometries; Reject large integer values read from geometry buffer, which prevents from OOM when reading malformed data; Fixed interoperability bugs in Python serde; drop M dimension when deserializing XYM or XYZM geometries instead of raising an exception.
jiayuasu
approved these changes
Feb 14, 2023
zongsizhang
pushed a commit
that referenced
this pull request
Feb 19, 2023
…ries containing only empty geometries (#766)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
This pull request fixes the handling of empty multi-geometries in the geometry serializer. In the current implementation, we omitted structure data for multi-geometries containing only empty geometries, such as
MULTILINESTRING (EMPTY, EMPTY). In this case, we cannot tell if it is an empty multi-geometry or multi-geometry containing only empty geometries. This patch fixes the problem by always writing structure data for multi geometries.This patch also fixes other issues with the geometry serializer:
How was this patch tested?
Unit tests were added to test this patch.
Did this PR include necessary documentation updates?