Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-179] Claim OGC compliance #755

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Conversation

BarbieQkiller
Copy link
Contributor

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

The most relevant parts of OGC sfs tests for Geometry types and functions are implemented.
Findings: Two functions are not compliant plus some functions are not implemented in Sedona.
Tests for those are ignored with comments.

How was this patch tested?

Test suite.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu
Copy link
Member

jiayuasu commented Feb 6, 2023

@BarbieQkiller Thanks for this great PR. I have updated SEDONA-179 to reflect the latest progress and I also created a number of tickets to fix these tests.

A few questions:

  1. I didn't see Test 51 here. Is there a particular reason?
  2. I didn't see PostGIS implements PolygonFromWKB for Test 9. Do you know how they handle this case?

Thanks,
Jia

@BarbieQkiller
Copy link
Contributor Author

@BarbieQkiller Thanks for this great PR. I have updated SEDONA-179 to reflect the latest progress and I also created a number of tickets to fix these tests.

A few questions:

  1. I didn't see Test 51 here. Is there a particular reason?
  2. I didn't see PostGIS implements PolygonFromWKB for Test 9. Do you know how they handle this case?

Thanks, Jia

Thank you for your kind response!

  1. I simply missed that one, apologies. I will update the PR.
  2. T9 verifies ST_AsBinary the missing PolygonFromWKB shouldn't be a problem.
    https://github.com/postgis/postgis/blob/f6def67654c25d812446239036cee44812613748/extras/ogc_test_suite/2_queries.sql#L255

Best regards
/Angela

@BarbieQkiller
Copy link
Contributor Author

Added the missing test.
BR,
/Angela

@jiayuasu jiayuasu changed the title [SEDONA-179] Claim OGC compliance. [SEDONA-179] Claim OGC compliance Feb 6, 2023
@jiayuasu jiayuasu merged commit 8f805fb into apache:master Feb 6, 2023
zongsizhang pushed a commit that referenced this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants