Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-230] rdd.saveAsGeoJSON should generate feature properties with field names #746

Merged
merged 7 commits into from
Jan 6, 2023

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Jan 6, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  1. SpatialRdd that has fields will be saved as a geojson that has correct property keys and values for each record.
  2. Null field value will be saved as empty space. E.g.,
"properties": {"name": ""}
  1. SpatialRdd that has no fields will be save as
"properties": null

One remaining issue is that numerical values in geojson will be converted to string type. To solve this, we need the full schema info preserved in SpatialRDD metadata. I will leave in this as the future work.

How was this patch tested?

Add a few more tests and passed existing tests

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu merged commit 4d23fb4 into master Jan 6, 2023
@jiayuasu jiayuasu deleted the rdd-save-geojson branch January 6, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant