[SEDONA-215] Add ST_ConcaveHull #737
Conversation
Adding ST_ConcaveHull to Sedona
docs/api/sql/Function.md
Outdated
|
|
||
| Format: `ST_ConcaveHull (A:geometry, pctConvex:float, allowHoles:Boolean)` | ||
|
|
||
| Since: `v1.3.1` |
There was a problem hiding this comment.
Sorry. Please change this to 1.3.2. I forgot to update the versions in POM file.
There was a problem hiding this comment.
Fixed in 59dcfb3
| @@ -12,6 +12,20 @@ SELECT ST_Distance(polygondf.countyshape, polygondf.countyshape) | |||
| FROM polygondf | |||
| ``` | |||
|
|
|||
| ## ST_ConcaveHull | |||
There was a problem hiding this comment.
Please do not update the archived GeoSpark func
There was a problem hiding this comment.
Fixed in 59dcfb3
There was a problem hiding this comment.
Please remove the change in the archive folder. Please add the new API t o Flink SQL doc as well.
| polygon_df.show() | ||
|
|
||
| function_df = self.spark.sql("select ST_ConcaveHull(polygondf.countyshape, 1.0) from polygondf") | ||
| function_df.show() |
There was a problem hiding this comment.
Please do not use show to verify the result. Use assertion to decide if a result is expected
There was a problem hiding this comment.
@jiayuasu This file follows the pattern of show type of tests only(reference is to all other tests in this file). The assert tests have been added to the test files following that pattern.
* Adding ST_ConcaveHull to Sedona * Updating release version * Removing ST_Concave from archived docs
Adding ST_ConcaveHull to flink
Added in 4985ef5 |
| @@ -12,6 +12,20 @@ SELECT ST_Distance(polygondf.countyshape, polygondf.countyshape) | |||
| FROM polygondf | |||
| ``` | |||
|
|
|||
| ## ST_ConcaveHull | |||
There was a problem hiding this comment.
Please remove the change in the archive folder. Please add the new API t o Flink SQL doc as well.
* [SEDONA-215] Add ST_ConcaveHull (#3)
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-215] Add ST_ConcaveHull.What changes were proposed in this PR?
Implementation of ST_ConcaveHull
How was this patch tested?
Scala, Python, and Java integration tests
Did this PR include necessary documentation updates?
v1.3.1format.